Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix:bitmap cache #2253

Merged
merged 13 commits into from
Jan 24, 2024
Merged

fix:bitmap cache #2253

merged 13 commits into from
Jan 24, 2024

Conversation

chejinge
Copy link
Collaborator

@chejinge chejinge commented Dec 28, 2023 •
edited by AlexStocks
Loading

#2284
#2267
#2266
#2283
#2285

这个PR
1.主要修复bitmap的cache
2.修复hgetall因为rocksdb会字典序，而cache非字典序导致的case不通过问题
3.cache支持config write
4.listpop update value未赋值初始值
5.修复cachecmd未判断传入参数数量的问题

@github-actions github-actions bot added the ☢️ Bug Something isn't working label Dec 28, 2023
u6th9d
u6th9d reviewed Jan 3, 2024
View reviewed changes
src/pika_conf.cc Outdated Show resolved Hide resolved
u6th9d
u6th9d reviewed Jan 3, 2024
View reviewed changes
src/pika_admin.cc Outdated Show resolved Hide resolved
u6th9d
u6th9d reviewed Jan 3, 2024
View reviewed changes
src/pika_admin.cc Outdated Show resolved Hide resolved
u6th9d
u6th9d reviewed Jan 3, 2024
View reviewed changes
conf/pika.conf Show resolved Hide resolved
Mixficsol
Mixficsol reviewed Jan 4, 2024
View reviewed changes
include/pika_conf.h Show resolved Hide resolved
src/pika_admin.cc Outdated Show resolved Hide resolved
Mixficsol
Mixficsol reviewed Jan 22, 2024
View reviewed changes
tests/integration/string_test.go Show resolved Hide resolved
src/pika_server.cc Outdated Show resolved Hide resolved
src/pika_server.cc Show resolved Hide resolved
@chejinge chejinge force-pushed the fix_bitmap_cache branch 2 times, most recently from 95ec2fb to c5d7b96 Compare January 23, 2024 08:52
@chejinge chejinge merged commit b640ad6 into OpenAtomFoundation:unstable Jan 24, 2024
13 checks passed
@chejinge chejinge deleted the fix_bitmap_cache branch January 29, 2024 07:13
bigdaronlee163 pushed a commit to bigdaronlee163/pika that referenced this pull request Jun 8, 2024
@chejinge @brother-jin
fix:bitmap cache (OpenAtomFoundation#2253)
c7373ba 
* fix:bitmap cache

Co-authored-by: chejinge <chejinge@360.cn>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@u6th9d u6th9d u6th9d approved these changes

@Mixficsol Mixficsol Mixficsol approved these changes

@dingxiaoshuai123 dingxiaoshuai123 Awaiting requested review from dingxiaoshuai123

Assignees
No one assigned
Labels
3.5.3 ☢️ Bug Something isn't working core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@chejinge @u6th9d @Mixficsol @AlexStocks @brother-jin